[Developers] [Patches] Make ADMConstraints GF public
goodale at cct.lsu.edu
Thu Aug 31 07:55:50 CDT 2006
if it's making a difference to results this needs to be investigated.
On Thu, 31 Aug 2006, Steve White wrote:
> I tried running the testsuites before and after applying the patch.
> I compiled in all the distro thorns I could (-= SDF, PETC, LAPACK etc)
> Find attached the results.
> With and without Franks patch 34 tests and 34 fail.
> Unfortunately the results are slightly different.
> On the other hand, there are just more error messages
> before the patch than after.
> This test seems to fail in somewhat different ways in the two cases
> I'm kind of in a rush, so it's hard for me to judge.
> What's the call?
> On 26.07.06, Frank Loeffler wrote:
>> this patch makes the GFs of CactusEinstein/ADMConstraints public.
>> The reason is that this way other thorns can use the values already
>> computed here for their own purposes by inheritage. One example of such
>> a thorn is ADMDevelopment/MaskedADMConstraints, which requires this
>> patch to work.
>> Another possibility to access these GF would be to get their pointer by
>> variable name. However, I would consider inheritage cleaner. I also
>> cannot see a reason why these variables should stay private.
>> Index: interface.ccl
>> RCS file: /cactusdevcvs/CactusEinstein/ADMConstraints/interface.ccl,v
>> retrieving revision 1.18
>> diff -u -r1.18 interface.ccl
>> --- interface.ccl 14 Feb 2005 09:50:26 -0000 1.18
>> +++ interface.ccl 26 Jul 2006 08:27:08 -0000
>> @@ -20,7 +20,7 @@
>> USES FUNCTION Boundary_SelectVarForBC
>> USES FUNCTION Boundary_SelectGroupForBC
>> real hamiltonian type=GF tags='tensortypealias="Scalar"'
>> Patches mailing list
>> Patches at cactuscode.org
More information about the Developers