[Developers] [Patches] more efficient synchronisation of groups

Tom Goodale goodale at cct.lsu.edu
Tue Jul 4 04:49:21 CDT 2006


Looks good to me.  Go ahead.

Cheers,

Tom


On Mon, 3 Jul 2006, Thomas Radke wrote:

> Tom Goodale wrote:
>> Looks good.  Just a few things to make the transition easier and safer:
>> 
>> * This will eventually completely replace the current overloading of 
>> CCTK_SyncGroup, so the default CCTK_SyncGroup should now call 
>> CCTK_SyncGroupByDirI.
>> 
>> * Overloading CCTK_SyncGroup should now produce a warning message saying 
>> this is deprecated and they should overload CCTK_SyncGroupByDirI.
>> 
>> * The default for CCTK_SyncGroupByDirI should check for a NULL directions 
>> array and then call CCTK_SyncGroup in a loop if CCTK_SyncGroup has been 
>> overloaded.  (This code will disappear once CCTK_SyncGroup is no longer 
>> overloadable.)
>> 
>> The intent of this is that drivers should only need to overload one of the 
>> functions, we preserve the current behaviour for drivers which have not 
>> been updated yet, and that we will be able to remove the overloading of 
>> CCTK_SyncGroup once we are sure all drivers have converted to the new 
>> mechanism.
>
> Okay, here is a revised version of the patches, implementing Tom's 
> suggestions from above plus a change in the prototypes for CCTK_SyncGroupsI() 
> and CCTK_SyncGroupsByDirI() where the array arguments are now passed as 
> 'CCTK_INT*' (rather than 'int*').
>
>


More information about the Developers mailing list