[Developers] Change to Cactus/lib/make/make.configuration
Tom Goodale
goodale at cct.lsu.edu
Wed Aug 22 11:32:35 CDT 2007
Ah, I see. What I meant was go with your original suggestion but with
custom instead of objectlist, although I hadn't appreciated the multiple
target issue. I.e go for
ifeq ($(suffix $(strip $(MAKECMDGOALS))), .custom)
-include $(CONFIG)/make.thornlist
endif
Cheers,
Tom
On Wed, 22 Aug 2007, Erik Schnetter wrote:
> Yes, that is the general idea.
>
> "custom" would not work, since it is only one target. I need several, one
> for each thorn library. What about any suffix which begins with "custom"
> ("custom*"), with suitable pattern matching?
>
> -erik
>
> On Aug 22, 2007, at 11:04:12, Tom Goodale wrote:
>
>> So the idea of this is to introduce a mechanism whereby you can recurse
>> over all thorns but not build them ?
>>
>> I think maybe having it called -custom might be a better name than
>> .objectlist - as the idea is to allow some custom processing from a
>> thorn's make.configuration.deps file, and Formaline just happens in this
>> instance to use it to generate an objectlist.
>>
>> Cheers,
>>
>> Tom
>>
>> On Wed, 22 Aug 2007, Erik Schnetter wrote:
>>
>>> Thorn Formaline creates tarballs for all thorn source code. Some
>>> architectures, noticeably AIX, have rather strict limits on the length of
>>> a
>>> command line, and Formaline can fail there if many thorns are used.
>>>
>>> It is very difficult to work around this problem, since only make knows
>>> the
>>> list of all thorns, and it cannot pass it to any shell function. This
>>> makes
>>> it also impossible to write this make variable into a file.
>>>
>>> One solution is to create a set of make rules, one rule per thorn, and
>>> then
>>> call make recursively. This happens in Formaline in
>>> make.configuration.deps,
>>> which is called from Cactus/lib/make/make.configuration.
>>>
>>> In order to make this work, the following lines need to be added to
>>> Cactus/lib/make/make.configuration:
>>>
>>> ifeq ($(suffix $(strip $(MAKECMDGOALS))), .objectlist)
>>> -include $(CONFIG)/make.thornlist
>>> endif
>>>
>>> These lines are very similar to the existing lines:
>>>
>>> ifeq ($(strip $(MAKECMDGOALS)),)
>>> -include $(CONFIG)/make.thornlist
>>> endif
>>>
>>> ifeq ($(strip $(MAKECMDGOALS)), utils)
>>> -include $(CONFIG)/make.thornlist
>>> endif
>>>
>>> ifeq ($(strip $(MAKECMDGOALS)), build)
>>> -include $(CONFIG)/make.thornlist
>>> endif
>>>
>>> This introduces a special case to Cactus/lib/make/make.configuration,
>>> which
>>> treats all make goals ending in ".objectlist" specially. At the moment,
>>> all
>>> goals ending in "-utils" and "-build" are treated specially.
>>>
>>> Is it okay to apply this patch?
>>>
>>> -erik
>>>
>>>
>> _______________________________________________
>> Developers mailing list
>> Developers at cactuscode.org
>> http://www.cactuscode.org/mailman/listinfo/developers
>>
>
>
>
More information about the Developers
mailing list