[Developers] [Patches] Optional capabilities

Erik Schnetter schnetter at cct.lsu.edu
Thu Dec 9 10:16:06 CST 2010


I have not tried it, but the overall design is good. If no one reviews
it, I suggest to apply it.

-erik

On Thu, Dec 9, 2010 at 8:24 AM, Ian Hinder <ian.hinder at aei.mpg.de> wrote:
>
> On 3 Dec 2010, at 18:03, Ian Hinder wrote:
>
> Improve optional requirement of capabilities
> Thorns can specify that they can make use of a particular capability (for
> example HDF5), but that it is not absolutely required.  It is currently not
> possible to detect a capability in the source code or make system  of a
> thorn because there is no preprocessor macro and no make variable defined to
> indicate that the capability is available.  Additionally, the preprocessor
> definitions which are explicitly provided by a capability are written to an
> include file which is malformed and hence these definitions cannot be read.
> This commit:
> * Introduces makefile and preprocessor variables HAVE_CAPABILITY_<cap> for
> each provided capability
> * Removes the incorrect definition line causing the include file to be
> malformed
> * Renames cctki_Capabilities.h to cctk_Capabilities.h and causes
> cctk_Capabilities.h to be included from cctk.h by all thorns
> * Excludes cctk_Capabilities.h from dependency checking (dependencies of the
> files included from this one will be sufficient)
>
> Please can somebody look at this and apply it if it is OK.  I have code
> which depends on this which I want to commit to the Einstein Toolkit.
> --
> Ian Hinder
> ian.hinder at aei.mpg.de
>
> _______________________________________________
> Developers mailing list
> Developers at cactuscode.org
> http://www.cactuscode.org/mailman/listinfo/developers
>
>



-- 
Erik Schnetter <schnetter at cct.lsu.edu>   http://www.cct.lsu.edu/~eschnett/


More information about the Developers mailing list